Working Like an Engineer: Git, PRs & Code Review · Lesson 6 of 6 · Bonus module

Commits and PRs an Interviewer Will Read

Your GitHub gets scrolled before you get interviewed. Commit messages and PR descriptions are the writing sample you didn't know you submitted.

By Shahriyar · Updated

Commit messages

Subject line: what changed and why, imperative, under ~70 characters. Add a body only when the why isn't obvious from the diff. The test: could a stranger pick your commit out of git log and know what it did without opening it?

▸ The difference, in four commits
# reads as rushed or copied
fix
final fix
now working
solution

# reads as an engineer
Add smoke tests for guest checkout
Wait for cart total before asserting — kills the flaky pass
Extract login steps into a fixture
Document the two skipped edge cases in the README

The PR description is the reviewer's README

Grounded in the git documentation and what reviewers actually scroll

All lessons in Working Like an Engineer: Git, PRs & Code Review

  1. The Loop: Branch, Commit, PR, Merge
  2. Your First Merge Conflict
  3. Reading Code You Didn't Write
  4. Receiving a Review Without Taking It Personally
  5. Giving a Review as the Quality Person
  6. Commits and PRs an Interviewer Will Read